Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mqtt] support mired<->Kelvin unit conversion #13575

Merged
merged 1 commit into from
Oct 22, 2022
Merged

[mqtt] support mired<->Kelvin unit conversion #13575

merged 1 commit into from
Oct 22, 2022

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Oct 20, 2022

Just have to use the newer toInvertibleUnit method that allows the dimension to change.

@ccutrer
[mqtt] support mired<->Kelvin unit conversion
2eeff23 
Just have to use the newer toInvertibleUnit method that allows
the dimension to change.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested a review from davidgraeff as a code owner October 20, 2022 18:54
lolodomo
lolodomo approved these changes Oct 22, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Oct 22, 2022
@lolodomo lolodomo merged commit 5f6241c into openhab:main Oct 22, 2022
@lolodomo lolodomo added this to the 3.4 milestone Oct 22, 2022
@ccutrer ccutrer deleted the mqtt-mireds branch October 23, 2022 16:01
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@ccutrer @andan67
[mqtt] support mired<->Kelvin unit conversion (openhab#13575)
f5ebd5b 
Just have to use the newer toInvertibleUnit method that allows
the dimension to change.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@ccutrer @andrasU
[mqtt] support mired<->Kelvin unit conversion (openhab#13575)
55ee949 
Just have to use the newer toInvertibleUnit method that allows
the dimension to change.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
@ccutrer @borazslo
[mqtt] support mired<->Kelvin unit conversion (openhab#13575)
da2cc0e 
Just have to use the newer toInvertibleUnit method that allows
the dimension to change.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@ccutrer @psmedley
[mqtt] support mired<->Kelvin unit conversion (openhab#13575)
24c03f2 
Just have to use the newer toInvertibleUnit method that allows
the dimension to change.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@ccutrer @nemerdaud
[mqtt] support mired<->Kelvin unit conversion (openhab#13575)
0f9fa9a 
Just have to use the newer toInvertibleUnit method that allows
the dimension to change.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ccutrer @lolodomo